Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 🧹 Removing the vendor dir #8054

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] 🧹 Removing the vendor dir #8054

wants to merge 5 commits into from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Jun 28, 2024

Tests knative/hack#386

Proposed Changes

  • 🧹 Removing the vendor dir

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 28, 2024
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jun 28, 2024
cardil
cardil commented Jun 28, 2024
View reviewed changes
go.mod Outdated
@@ -50,6 +50,8 @@ require (
sigs.k8s.io/yaml v1.4.0
)

replace knative.dev/hack => github.com/cardil/knative-hack v0.0.0-20240627155243-4b5dad135546
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Don't merge with this replace

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.87%. Comparing base (2cc0a5b) to head (85df2bb).
Report is 61 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8054   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files         368      368           
  Lines       17551    17551           
=======================================
  Hits        11912    11912           
  Misses       4894     4894           
  Partials      745      745

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil cardil force-pushed the chore/vendorless branch 4 times, most recently from dff4435 to b89a4a7 Compare July 2, 2024 10:32
@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024

/test all

@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024

/override "Code Style / style / Golang / Lint"

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 2, 2024

@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Code Style / style / Golang / Lint

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-tests_eventing_main
  • conformance-tests_eventing_main
  • reconciler-tests_eventing_main
  • style / Golang / Lint
  • tide
  • unit-tests_eventing_main
  • upgrade-tests_eventing_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Code Style / style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Contributor Author

cardil commented Jul 2, 2024 •
edited
Loading

/override "style / Golang / Lint"

The lint reports files outside of the change context: https://github.com/knative/eventing/actions/runs/9759383289/job/26938506393?pr=8054

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 2, 2024

@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2024
@cardil
Copy link
Contributor Author

cardil commented Jul 9, 2024

/test all

@cardil cardil mentioned this pull request Jul 9, 2024
Merged
@cardil
Copy link
Contributor Author

cardil commented Jul 10, 2024

/override "style / Golang / Lint"

The Golang-lint reports files outside the change context, because of a large PR:

Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.

See: https://github.com/knative/eventing/actions/runs/9861887873/job/27231331728?pr=8054

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 10, 2024

@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

The Golang-lint reports files outside the change context, because of a large PR:

Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.

See: https://github.com/knative/eventing/actions/runs/9861887873/job/27231331728?pr=8054

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@cardil
Copy link
Contributor Author

cardil commented Jul 18, 2024

/override "style / Golang / Lint"

Ref.:

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 18, 2024

@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Ref.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Contributor Author

cardil commented Jul 19, 2024

/test all

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 19, 2024

@cardil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing_main 85df2bb link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024
@github-actions GitHub Actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr Awaiting requested review from creydr

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees
No one assigned
Labels
area/test-and-release Test infrastructure, tests or release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardil @knative-prow-robot